fix: enables multi-platform support for OCI images #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We use the commit messages to generate our release notes. Could you update the message to briefly explain the changes you made in a way that's easy to understand for users who might not be familiar with the code itself? For example, instead of This will help us create even better release notes for everyone! |
pecodez
force-pushed
the
fix/bumps-sdp-v6.10.3
branch
from
b4f2ba2
to
38002a3
Compare
ChristinaDara
force-pushed
the
fix/bumps-sdp-v6.10.3
branch
from
38002a3
to
8cc9a3e
Compare
cmars
approved these changes
Mar 4, 2024
pecodez
force-pushed
the
fix/bumps-sdp-v6.10.3
branch
from
8cc9a3e
to
d0972c9
Compare
pecodez
changed the title
This fixes a bug that restricted scanning OCI images to linux/amd64 only. We now also ensure the provided --platform flag is used to correctly identify the appropriate manifests for images that have multiple platforms.
pecodez
force-pushed
the
fix/bumps-sdp-v6.10.3
branch
from
d0972c9
to
ac14262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables multi-platform support for OCI images.
How should this be manually tested?
Using Docker engine 25.x test an OCI image with a non-standard platform...
snyk container test busybox:latest --platform=linux/arm64Any background context you want to provide?
Docker engine 25.x now creates an archive with a compliant OCI layout when running
docker save. We previously only supportedlinux/amd64for OCI layouts.snyk/snyk-docker-plugin#571
What are the relevant tickets?
https://snyksec.atlassian.net/browse/SUP-2577
https://snyksec.atlassian.net/browse/SUP-2579
https://snyksec.atlassian.net/browse/SUP-2594
https://snyksec.atlassian.net/browse/SUP-2595
https://snyksec.atlassian.net/browse/SUP-2630