Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for dev/alpha/beta/rc python versions #5106

Merged

Conversation

MarcusArdelean
Copy link
Contributor

@MarcusArdelean MarcusArdelean commented Mar 12, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Adds support for development, alpha, beta and release candidate python versions.

Now we will support the following python versions:

  • Stable release versions: 3.9.2
  • Wildcard versions: 3.9.*
  • Development versions: 3.9.dev0
  • Alpha release versions: 3.9.a1
  • Beta release versions: 3.9.b2
  • Release candidate versions: 3.9.rc01

Any background context you want to provide?

Some clients are using Poetry in order to generate a requirements.txt file. By default, poetry uses development versions to restrict the instalation of some packages, and until now we were not handling those versions only stable releases and wildcard versions.

What are the relevant tickets?

Support ticket SUP-2503

@MarcusArdelean MarcusArdelean requested a review from a team as a code owner March 12, 2024 07:27
@MarcusArdelean MarcusArdelean self-assigned this Mar 12, 2024
@MarcusArdelean MarcusArdelean enabled auto-merge (squash) March 12, 2024 14:42
@MarcusArdelean MarcusArdelean force-pushed the fix/add-support-for-development-python-versions branch from 9cb6d03 to d2190fb Compare March 12, 2024 14:55
@thisislawatts thisislawatts changed the title fix: fix add support for dev/alpha/beta/rc python versions fix: add support for dev/alpha/beta/rc python versions Mar 12, 2024
@MarcusArdelean MarcusArdelean force-pushed the fix/add-support-for-development-python-versions branch from d2190fb to 14ce106 Compare March 13, 2024 07:16
@MarcusArdelean MarcusArdelean merged commit bd6351a into main Mar 13, 2024
14 checks passed
@MarcusArdelean MarcusArdelean deleted the fix/add-support-for-development-python-versions branch March 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants