Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger re-analysis after fixing interfile issues [IDE-178] #5163

Merged
merged 1 commit into from Apr 16, 2024

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Apr 15, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

What does this PR do?

This PR bumps Snyk-LS & Code-Client-Go. This enables correct automatic rescans in Snyk Code for interfile issues, where e.g. the cause of a problem is fixed in a different file, and the affected file is automatically fixed with the cause. This dataflow analysis was previously missing from re-scans, so the analysis was limited to too few files.

Risk: Low

Code-Client-Go is only used behind a feature flag. This updates to the latest version used in unified ignores (under development)

Risk: Low

Where should the reviewer start?

snyk/snyk-ls#486

How should this be manually tested?

Fire up IntelliJ, enable Snyk Code LS scanning, and scan a project with interfile issues. Fix the cause in one file, watch the issue disappear for the other file. I used juice-shop, it has some interfile issues.

Any background context you want to provide?

What are the relevant tickets?

IDE-178

Screenshots

Additional questions

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner April 15, 2024 14:56
@PeterSchafer PeterSchafer force-pushed the fix/IDE-178_fix_interfile_code_issues branch from b169d96 to b8c6a3e Compare April 16, 2024 07:36
@PeterSchafer PeterSchafer enabled auto-merge (squash) April 16, 2024 07:37
@PeterSchafer PeterSchafer merged commit 05cb9f5 into main Apr 16, 2024
15 checks passed
@PeterSchafer PeterSchafer deleted the fix/IDE-178_fix_interfile_code_issues branch April 16, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants