You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the above code, a new method was added to the mapping parser to support a specific Elasticsearch version. This pattern presents issues b/c it requires conditional logic to use the method (you have to know which version you want and which methods go with which version...). The usual solution would be to add a new mapping parser implementer (specific to a ES version) that conforms to the mapping parser interface.
The text was updated successfully, but these errors were encountered:
erhathaway
changed the title
RFC: Implement mapping parsers specific to ES versions
RFC: Use mapping parser implementers instead of extending interface to support different versions
May 6, 2021
elastic-composer/src/mapping_parser.ts
Line 36 in 31b3db6
In the above code, a new method was added to the mapping parser to support a specific Elasticsearch version. This pattern presents issues b/c it requires conditional logic to use the method (you have to know which version you want and which methods go with which version...). The usual solution would be to add a new mapping parser implementer (specific to a ES version) that conforms to the mapping parser interface.
@markrsocialnative @dearsaturn
The text was updated successfully, but these errors were encountered: