Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install docs for v3, slim build missing #1401

Open
hyperknot opened this issue Nov 11, 2020 · 2 comments
Open

Update install docs for v3, slim build missing #1401

hyperknot opened this issue Nov 11, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@hyperknot
Copy link

The install docs have not been updated for v3. There is no slim build anymore, is it on purpose?

If so, which bundle do you recommend for development and which one for production? Or there isn't any differentiation anymore?

Before I had this in webpack aliases:

let socketioClient
if (process.env.NODE_ENV === 'development') {
  socketioClient = 'socket.io-client/dist/socket.io.dev.js'
} else {
  socketioClient = 'socket.io-client/dist/socket.io.slim.js'
}
@darrachequesne
Copy link
Member

The documentation was updated: https://socket.io/docs/v3/client-installation/

Basically:

  • socket.io-client/dist/socket.io.dev.js => socket.io-client/dist/socket.io.js
  • socket.io-client/dist/socket.io.slim.js => socket.io-client/dist/socket.io.min.js

@darrachequesne darrachequesne added the documentation Improvements or additions to documentation label Nov 12, 2020
@hyperknot
Copy link
Author

But with any recent Webpack setup (like recent create-react-app), basically there is no need to specify anything, right? You just import socket.io-client and everything will be set. So the whole custom alias setup I used for v2 can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants