Skip to content

Commit 1a72ae4

Browse files
solomon23darrachequesne
authored andcommittedMar 18, 2021
fix(typings): update return type from emit (#3843)
``` (channel ? io.to(channel) : io).emit("stuff", message); ``` would no longer compile. Related: #3844
1 parent 5eaeffc commit 1a72ae4

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed
 

‎lib/broadcast-operator.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export class BroadcastOperator<EmitEvents extends EventsMap>
133133
public emit<Ev extends EventNames<EmitEvents>>(
134134
ev: Ev,
135135
...args: EventParams<EmitEvents, Ev>
136-
): true {
136+
): boolean {
137137
if (RESERVED_EVENTS.has(ev)) {
138138
throw new Error(`"${ev}" is a reserved event name`);
139139
}
@@ -276,7 +276,7 @@ export class RemoteSocket<EmitEvents extends EventsMap>
276276
public emit<Ev extends EventNames<EmitEvents>>(
277277
ev: Ev,
278278
...args: EventParams<EmitEvents, Ev>
279-
): true {
279+
): boolean {
280280
return this.operator.emit(ev, ...args);
281281
}
282282

‎lib/namespace.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ export class Namespace<
229229
public emit<Ev extends EventNames<EmitEvents>>(
230230
ev: Ev,
231231
...args: EventParams<EmitEvents, Ev>
232-
): true {
232+
): boolean {
233233
return new BroadcastOperator<EmitEvents>(this.adapter).emit(ev, ...args);
234234
}
235235

‎lib/parent-namespace.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class ParentNamespace<
3535
public emit<Ev extends EventNames<EmitEvents>>(
3636
ev: Ev,
3737
...args: EventParams<EmitEvents, Ev>
38-
): true {
38+
): boolean {
3939
this.children.forEach((nsp) => {
4040
nsp.emit(ev, ...args);
4141
});

0 commit comments

Comments
 (0)
Please sign in to comment.