-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: socketio/socket.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.0.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: socketio/socket.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.0.5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 57 files changed
- 3 contributors
Commits on Dec 11, 2020
-
refactor: add more typing info and upgrade prettier (#3725)
This upgrades prettier to 2.2.0 to gain support for TypeScript's new type-only-imports feature.
Configuration menu - View commit details
-
Copy full SHA for d1bfe40 - Browse repository at this point
Copy the full SHA d1bfe40View commit details
Commits on Dec 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 178e899 - Browse repository at this point
Copy the full SHA 178e899View commit details
Commits on Dec 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 292d62e - Browse repository at this point
Copy the full SHA 292d62eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f773b48 - Browse repository at this point
Copy the full SHA f773b48View commit details
Commits on Jan 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a0a3481 - Browse repository at this point
Copy the full SHA a0a3481View commit details -
Configuration menu - View commit details
-
Copy full SHA for 230cd19 - Browse repository at this point
Copy the full SHA 230cd19View commit details
Commits on Jan 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 170b739 - Browse repository at this point
Copy the full SHA 170b739View commit details -
revert: restore the socket middleware functionality
This functionality was removed in [1] (included in 3.0.0), but catch-all listeners and socket middleware features are complementary rather than mutually exclusive. The only difference with the previous implementation is that passing an error to the `next` handler will create an error on the server-side, and not on the client-side anymore. ```js io.on("connection", (socket) => { socket.use(([ event, ...args ], next) => { next(new Error("stop")); }); socket.on("error", (err) => { // to restore the previous behavior socket.emit("error", err); // or close the connection, depending on your use case socket.disconnect(true); }); }); ``` This creates additional possibilities about custom error handlers, which may be implemented in the future. ```js // user-defined error handler socket.use((err, [ event ], next) => { // either handle it socket.disconnect(); // or forward the error to the default error handler next(err); }); // default error handler socket.use((err, _, next) => { socket.emit("error", err); }); ``` Related: #3678 [1]: 5c73733
Configuration menu - View commit details
-
Copy full SHA for bf54327 - Browse repository at this point
Copy the full SHA bf54327View commit details -
Configuration menu - View commit details
-
Copy full SHA for 752dfe3 - Browse repository at this point
Copy the full SHA 752dfe3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8a66fd - Browse repository at this point
Copy the full SHA f8a66fdView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 3.0.4...3.0.5