Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.5.1
Choose a base ref
...
head repository: socketio/socket.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.5.2
Choose a head ref
  • 7 commits
  • 30 files changed
  • 3 contributors

Commits on May 25, 2022

  1. fix: prevent the socket from joining a room after disconnection 

    Calling `socket.join()` after disconnection would lead to a memory
leak, because the room was never removed from the memory:

```js
io.on("connection", (socket) => {
  socket.disconnect();
  socket.join("room1"); // leak
});
```

Related:

- #4067
- #4380
    @darrachequesne
    darrachequesne committed May 25, 2022
    Copy the full SHA
    18f3fda View commit details

Commits on Jun 27, 2022

  1. chore: bump mocha to version 10.0.0 

    Related: #3710
    @darrachequesne
    darrachequesne committed Jun 27, 2022
    Copy the full SHA
    713a6b4 View commit details

  2. chore: bump dependencies 

    Production:

- socket.io-parser: ~4.0.4 => ~4.2.0

Development:

- superagent: ^6.1.0 => ^8.0.0
- tsd: ^0.17.0 => ^0.21.0

Related: #3709
    @darrachequesne
    darrachequesne committed Jun 27, 2022
    Copy the full SHA
    9890b03 View commit details

Commits on Sep 1, 2022

  1. refactor: add missing constraints (#4431) 

    See also: microsoft/TypeScript#49489
    @DanielRosenwasser
    DanielRosenwasser authored Sep 1, 2022
    Copy the full SHA
    134226e View commit details

Commits on Sep 2, 2022

  1. ci: add explicit permissions to workflow (#4466) 

    Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
    @sashashura
    sashashura authored Sep 2, 2022
    Copy the full SHA
    2803871 View commit details

  2. fix(uws): prevent the server from crashing after upgrade 

    This should fix a rare case where the Engine.IO connection was upgraded
to WebSocket while the Socket.IO socket was disconnected, which would
result in the following exception:

> TypeError: Cannot read properties of undefined (reading 'forEach')
>    at subscribe (/node_modules/socket.io/dist/uws.js:87:11)
>    at Socket.<anonymous> (/node_modules/socket.io/dist/uws.js:28:17)
>    at Socket.emit (node:events:402:35)
>    at WebSocket.onPacket (/node_modules/engine.io/build/socket.js:214:22)
>    at WebSocket.emit (node:events:390:28)
>    at WebSocket.onPacket (/node_modules/engine.io/build/transport.js:92:14)
>    at WebSocket.onData (/node_modules/engine.io/build/transport.js:101:14)
>    at message (/node_modules/engine.io/build/userver.js:56:30)

Related: #4443
    @darrachequesne
    darrachequesne committed Sep 2, 2022
    Copy the full SHA
    ba497ee View commit details

  3. chore(release): 4.5.2 

    Diff: 4.5.1...4.5.2
    @darrachequesne
    darrachequesne committed Sep 2, 2022
    Copy the full SHA
    8be95b3 View commit details
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -6,6 +6,9 @@ on:
schedule:
- cron: '0 0 * * 0'

permissions:
contents: read

jobs:
test-node:
runs-on: ubuntu-latest
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## [4.5.2](https://github.com/socketio/socket.io/compare/4.5.1...4.5.2) (2022-09-02)


### Bug Fixes

* prevent the socket from joining a room after disconnection ([18f3fda](https://github.com/socketio/socket.io/commit/18f3fdab12947a9fee3e9c37cfc1da97027d1473))
* **uws:** prevent the server from crashing after upgrade ([ba497ee](https://github.com/socketio/socket.io/commit/ba497ee3eb52c4abf1464380d015d8c788714364))



## [4.5.1](https://github.com/socketio/socket.io/compare/4.5.0...4.5.1) (2022-05-17)


Loading