Code optimization #2219
Closed
Code optimization #2219
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrachequesne
pushed a commit
that referenced
this pull request
Nov 18, 2016
|
Merged as ff2c15d. Thanks! |
|
My pleasure :) |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking at how
socket.ioworked internally (which by the way, great job!) I spotted some code which can be optimized (b37f976) and standardised (906cdae).Also replaced deprecated defineGetter() with defineProperty().
All changes were tested successfully (of course after including PR #2193).