Fix for Issue #331 on socket.io-client #2422
Merged
+41
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parses CONNECT packet for query string and replaces query in socket.handshake.
Fix for Issue socketio#331 on socket.io-client
* master: Release 1.4.5 package: bump `engine.io` add a test for graceful shutdown
sync to master branch
add test for issue socketio#331 on socket.io-client.
add comments to code
update package.son to point to latest commit in socket.o-client package (with URI encoder)
Query string fix
add test to test decoding function.
…t.io into queryStringFix # By whattokingu # Via whattokingu * 'queryStringFix' of https://github.com/whattokingu/socket.io: conform to style guide Conflicts: lib/client.js
Query string fix
|
Thanks!! |
|
This pull request seems to lead to errors with query strings getting stripped. (#2712) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side implementation of the fix for issue #331.
Client fix on PR #943 on socket.io-client