Skip to content

Fix chat display in Firefox #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2016
Merged

Conversation

callahad
Copy link
Contributor

@callahad callahad commented Mar 9, 2016

Not sure why .username was floated, but it causes the messages to steadily march to the right in Firefox, per screenshot:

socket

Removing the float (or setting .messages > * { clear: both; }) results in identical, correct display in both Chrome and Firefox.

@callahad
Copy link
Contributor Author

ping @rauchg

@nkzawa
Copy link
Contributor

nkzawa commented Apr 11, 2016

Thanks. it's weird but this happens only on Firefox for Windows, not on Firefox for Mac.

@nkzawa nkzawa merged commit 0ae0708 into socketio:master Apr 11, 2016
@nkzawa nkzawa mentioned this pull request Apr 11, 2016
@callahad
Copy link
Contributor Author

Odd, I was seeing it on Mac (note the scrollbar in the screenshot), but hey, now it should work everywhere for everyone. Thanks for merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants