Feature - added support for Server#close(callback) #2748
Merged
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatcharinMakkarjang
approved these changes
Nov 13, 2016
| @@ -355,7 +355,7 @@ Server.prototype.of = function(name, fn){ | |||
| * @api public | |||
| */ | |||
|
|
|||
| Server.prototype.close = function(){ | |||
| @@ -355,7 +355,7 @@ Server.prototype.of = function(name, fn){ | |||
| * @api public | |||
| */ | |||
|
|
|||
| Server.prototype.close = function(){ | |||
| Server.prototype.close = function(fn){ | |||
There was a problem hiding this comment.
Could you update the JSDoc with the optional argument please?
There was a problem hiding this comment.
I saw you updated the docs (thanks!), could you also update the jsdoc (above @api public, line 354-355) please?
|
@mhmeadows63 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Previously unable to pass a
donecallback to theServer#close()method.New behaviour
Now able to pass a
donecallback to theServer#close()method.Other information (e.g. related issues)
candidate for #2739