Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Purgatory from Doctrine annotations #49

Open
lskupnjak opened this issue Feb 23, 2023 · 0 comments
Open

Decouple Purgatory from Doctrine annotations #49

lskupnjak opened this issue Feb 23, 2023 · 0 comments
Assignees
@Brajk19
Labels
priority-high

Comments

@lskupnjak
Copy link
Contributor

lskupnjak commented Feb 23, 2023 •
edited by HypeMC

  • rename Annotation namespace to Attribute
  • rename AnnotationReader namespace to AttributeReader
  • remove DriverInterface
  • remove AttributeReader, Reader should be enough?
  • see why Reader has unnecessary public methods?
@lskupnjak lskupnjak added good first issue Good for newcomers priority-high and removed good first issue Good for newcomers labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brajk19 Brajk19

Labels
priority-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lskupnjak @Brajk19