Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用demo,线程泄露是需要注意什么 #233

Open
ji-hang opened this issue Jul 25, 2020 · 1 comment
Open

使用demo,线程泄露是需要注意什么 #233

ji-hang opened this issue Jul 25, 2020 · 1 comment
Assignees
Milestone

Comments

@ji-hang
Copy link

ji-hang commented Jul 25, 2020

你好,请问中RpcClient中startup()方法里的this.connectionManager.startup(); 中
this.connectionEventHandler.setConnectionEventListener(connectionEventListener); 会创建一个线程池,
RpcClient执行shutdown后这个线程就会一直处于WAITING状态,是需要注意什么么

@dbl-x
Copy link
Contributor

dbl-x commented Aug 23, 2021

这是一个不好的实现,没有管理好内部的eventExecutor,应该让它跟着RpcClient一起被回收掉。
我后面的版本会修复这个问题。

@dbl-x dbl-x self-assigned this Aug 23, 2021
@dbl-x dbl-x added this to the 1.6.5 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants