Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases coverage is low and we should supply more test cases #16

Open
guanchao-yang opened this issue Jun 4, 2018 · 0 comments
Open

Test cases coverage is low and we should supply more test cases #16

guanchao-yang opened this issue Jun 4, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@guanchao-yang
Copy link
Member

No description provided.

@guanchao-yang guanchao-yang mentioned this issue Jun 4, 2018
Merged
khotyn pushed a commit that referenced this issue Jun 5, 2018
@guanchao-yang @khotyn
Compatible old ReportUtil usage and supply test cases (#14)
8bb9f92 
## Motivation

Before some alipay users use ReportUtil with the full package com.alipay.sofa.common.log.ReportUtil but in this version ReportUtil has been moved to com.alipay.sofa.common.utils.ReportUtil. Consider many users has used, so we should be compatible with it

## Modification

com.alipay.sofa.common.log.ReportUtil extends com.alipay.sofa.common.utils.ReportUtil for compatible

## Result

Fixes #14

#16 only litte cases and after should provide more test cases
@guanchao-yang guanchao-yang added the enhancement New feature or request label Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guanchao-yang