Remove log4j2 Strings import && bump commons-lang to commons-lang3 #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aofall, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
|
I have signed the CLA but the status of the bot is still unsigned, can anyone help?
|
|
Would you please reopen the pr so that we could look into this cla issue? cc @zhenjunMa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The usage of Log4j2 Strings Util class in the code makes users force dependency on log4j2. We can use commons-lang instead or maintain self Utils of String in the project.
Modification:
Bump commons-lang to commons-lang3. And used the commons-lang3 to instead
Stringsusage of Log4j2 in the code.Result:
Fixes #345 .