Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onPress not work correctly #5977

Open
pigeonmal opened this issue May 5, 2024 · 4 comments
Open

onPress not work correctly #5977

pigeonmal opened this issue May 5, 2024 · 4 comments
Labels
Platform: Android This issue is specific to Android Repro provided A reproduction with a snippet of code, snack or repo is provided

Comments

@pigeonmal
Copy link

Description

(first i thought is bug from react-native, but after checks, is from react-native-reanimated)
I try to create my bottom sheet.
onPress work only one time, when pressable component is in root. Sometimes it's just the first time click, sometimes is after many clicks, and after does not work anymore.
onPressIn work perfectly

The bug is on v0.73.7 (new arch, bridgless false) and v0.74.0 (new arch, bridgless true), tested only on Android.

This is video of the bug:

Record_2024-04-24-22-06-44.mp4

Steps to reproduce

(TEST ON ANDROID, v0.73.7, and v0.74.0, new arch)

  1. clone my reproducer
  2. try building, and verify the bug

Snack or a link to a repository

https://github.com/pigeonmal/react-native-onpress-bug

Reanimated version

3.9.0

React Native version

0.74.0

Platforms

Android

JavaScript runtime

Hermes

Workflow

React Native

Architecture

Fabric (New Architecture)

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added Platform: Android This issue is specific to Android Repro provided A reproduction with a snippet of code, snack or repo is provided labels May 5, 2024
@v27855
Copy link

v27855 commented May 21, 2024

Familiar issue from my project, a few things I tried for my case:

  1. My React Native version is 0.72.7, and the Reanimated version is 3.7.1. This issue only occurs on Android.
  2. If I upgrade Reanimated to 3.10.*, this issue will be resolved, but it will cause another initialization issue for both iOS and Android.
  3. The issue affects onPress and onLongPress, while onPressIn and onPressOut work fine, but it's not ideal to use them.
  4. It is related to the Animate.View component from Reanimated. The issue is resolved if I use Animate.View from React Native instead.
  5. Not related to react-native-gesture-handler (Updated from below)
  6. This issue only occurs in the build version on Android.
  7. Not all the Animate.View from Reanimated has this issue, only wrapped by a parent component which has position: absolute

@pigeonmal
Copy link
Author

2. If I upgrade Reanimated to 3.10.*, this issue will be resolved, but it will cause another initialization issue for both iOS and Android.

Oh I will try to update to 3.10 for test, but what is your initialization issue ?

@v27855
Copy link

v27855 commented May 24, 2024

Few updates for this issue:

  1. This issue only occurred on Samsung Devices, tested on Galaxy s22.
  2. I updated reanimated to 3.10.0, and react-native to 0.74.1. The initialization issue disappeared. But the onPress issue still exists.
  3. Found this issue on stackoverflow, which is similar case for me. Now it may related to react-native-gesture-handler.
  4. The onPress event can triggered through the remote of Android Studio.

You may try using onPressIn to check is that we are same issue

Now I'm confused and hopeless on this issue, after making a big effort to upgrade the react-native and finding out it may not related to the version of reanimated.

@pigeonmal
Copy link
Author

onPressIn work perfectly

Yes for me onPressIn work perfectly like you, so I think it's the same issue.
I try to update to 0.74.1, and reanimated to 3.11.0, and still the same issue. (I tested on android phone, not samsung). Check my reproducer https://github.com/pigeonmal/react-native-onpress-bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android This issue is specific to Android Repro provided A reproduction with a snippet of code, snack or repo is provided
Projects
None yet
Development

No branches or pull requests

2 participants