fix: add internal isNewBackTitleImplementation const #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
changed the title
kacperkapusciak
changed the title
WoLewicki
approved these changes
Jun 16, 2023
src/utils.ts
Outdated
|
|
||
| // Because of a bug introduced in https://github.com/software-mansion/react-native-screens/pull/1646 | ||
| // react-native-screens v3.21 changed how header's backTitle handles whitespace strings in https://github.com/software-mansion/react-native-screens/pull/1726 | ||
| // To allow for backwards compatibility in @react-navigation/native-stack we need have a way to check if this version or newer is used |
There was a problem hiding this comment.
Suggested change
| // To allow for backwards compatibility in @react-navigation/native-stack we need have a way to check if this version or newer is used | |
| // To allow for backwards compatibility in @react-navigation/native-stack we need a way to check if this version or newer is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of a bug introduced in #1646
react-native-screensv3.21 changed how header's backTitle handles whitespace strings in #1726To allow for backwards compatibility in @react-navigation/native-stack we need have a way to check if this version or newer is used
See react-navigation/react-navigation#11423 for more context.
Changes
Added new
isNewBackTitleImplementationinternal constant that can be used in@react-navigation/native-stack.Screenshots / GIFs
This change & react-navigation/react-navigation#11423 applied:
Screen.Recording.2023-06-16.at.15.12.46.mov
Without this change and react-navigation/react-navigation#11423:
Screen.Recording.2023-06-16.at.15.14.19.mov
Test code and steps to reproduce
Test1791.tsx
You need to apply changes introduced in react-navigation/react-navigation#11423 to
@react-navigation/native-stackto test these canges.Checklist