feat: export new prop for web #709
Conversation
src/index.js
Outdated
| let { active, activityState, style, enabled = true, ...rest } = this.props; | ||
| if (active !== undefined && activityState === undefined) { | ||
| console.warn( | ||
| 'It appears that you are using old version of react-navigation library. Please update @react-navigation/bottom-tabs, @react-navigation/stack and @react-navigation/drawer to version 5.10.0 or above to take full advantage of new functionality added to react-native-screens' |
There was a problem hiding this comment.
I'm not sure about this warning. This doesn't necessarily mean that it's used by React Navigation. This warning will also appear in 4.x versions of React Navigation libs which won't be easy to upgrade.
There was a problem hiding this comment.
I added the same warning in index.native.js. I think we would like to inform users that upgrading react-native-screens without the update of react-navigation can result in some bugs. How would you see it?
There was a problem hiding this comment.
@WoLewicki I thought use of old API should stay the same, no? btw we'll drop use of old API in v6 entirely.
There was a problem hiding this comment.
On the native side, the old API was removed, the new one can be not entirely compatible.
There was a problem hiding this comment.
Hmm, maybe consider bumping the version to major if the change isn't backward compatible.
Description
Export
shouldUseActivityStatein web. Fixes #701 .Changes
Added
shouldUseActivityStateto the exported constants inindex.jswithtruevalue, which can be useful when the support foractiveprop is dropped in thereact-navigation.Checklist