Skip to content

feat: add setting frame in notifyWillAppear #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2021
Merged

feat: add setting frame in notifyWillAppear #772

merged 2 commits into from
Jan 18, 2021
+44 −0

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Jan 12, 2021 •
edited
Loading

Description

Suggested by @kmagiera change adding setting frame in the viewWillAppear. It ensures that the parentViewController is set when trying to set the frame, and if the parent is not UINavigationController, then the frame is properly set. It fixes the issue that appeared after #712 was merged, where there is a check for parentViewController not being nil introduced. The issue can be spotted and should fix #750.

Changes

Added setting frame in notifyWillAppear.

Screenshots / GIFs

Before

image

After

image

-->

Test code and steps to reproduce

Test750.js in TestsExample project.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

Sorry, something went wrong.

@WoLewicki WoLewicki mentioned this pull request Jan 12, 2021
Closed
kmagiera
kmagiera reviewed Jan 12, 2021
View reviewed changes
kmagiera
kmagiera approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this code we veryfi if a parent is an UINavController not the controller itself. I added a note on that in the comment you added in RNScreen.m but please also update the PR description to match that

WoLewicki
WoLewicki commented Jan 12, 2021
View reviewed changes
@WoLewicki
Update ios/RNSScreen.m

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2509181
@WoLewicki WoLewicki merged commit 75bbabf into master Jan 18, 2021
@WoLewicki WoLewicki deleted the @wolewicki/fix-set-frame branch January 18, 2021 15:55
@mahi8813
Copy link

Hi, Can we have a release with the fix pls

WoLewicki added a commit that referenced this pull request Jan 19, 2021
@WoLewicki
feat: apply #772
bf952cb
@WoLewicki WoLewicki mentioned this pull request Jan 19, 2021
Merged
WoLewicki added a commit that referenced this pull request Jan 19, 2021
@WoLewicki
Apply #712 and #772 on top of 2.15.0 (#778)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
60b04ab 
PR adding #712 and #772 to 2.15.0 for patch release of Expo SDK 40.
This was referenced Mar 15, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmagiera kmagiera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.16.1] - Lazy loaded tabs renders stack headers without safe area insets.
3 participants
@WoLewicki @mahi8813 @kmagiera