Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop buffering whole Scarb stdout in MetadataCommand #1102

Open
maciektr opened this issue Jan 31, 2024 · 0 comments
Open

Stop buffering whole Scarb stdout in MetadataCommand #1102

maciektr opened this issue Jan 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@maciektr
Copy link
Contributor

Problem

As of #1098 the MetadataCommand allows Scarb stdout inheritance. Unfortunately, the current implementation buffers whole output inside and prints it all at the end. For instance, if Scarb subprocess encounters an error, the current implementation will not be able to show any output messages to the user.

Proposed solution

MetadataCommand should stop buffering output and work on some kind of stream instead, passing output to stdout line-by-line, while searching for metadata json.

Acceptance criteria:

  • Scarb output is passed to stdout from MetadataCommand on the fly
  • output color is handled properly
  • isatty is set correctly on the child process
@maciektr maciektr added the bug Something isn't working label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant