scarb package is crashing on invalid symlinks which should be ignored from the package

[mkaput]

Problem

The following test currently asserts failure because of implementation simplifications:

scarb/scarb/tests/package.rs

Lines 644 to 667 in 0951e2a

	#[test]
	fn broken_but_excluded_symlink() {
	let t = TempDir::new().unwrap();
	ProjectBuilder::start()
	.name("foo")
	.version("1.0.0")
	.build(&t);
	symlink_dir("nowhere", t.child("target"));
	// FIXME(mkaput): Technically, we can just ignore such symlinks.
	Scarb::quick_snapbox()
	.arg("package")
	.current_dir(&t)
	.assert()
	.failure()
	.stdout_matches(indoc! {r#"
	[..] Packaging [..]
	error: failed to list source files in: [..]
	Caused by:
	[..]
	"#});
	}

Actually, what could happen here is that we can successfully create the tarball because the invalid symlink shouldn't be visited by the packaging process (it should be filtered out by dirwalker).

Steps

No response

Possible Solution(s)

Expand this logic:

scarb/scarb/src/core/publishing/source.rs

Lines 68 to 74 in 0951e2a

	.try_for_each(|entry| {
	let entry = entry?;
	if !is_dir(&entry) {
	ret.push(entry.into_path().try_into_utf8()?);
	}
	Ok(())
	})

to do something like this: https://github.com/rust-lang/cargo/blob/af1a78b424db7d517a359fd23d548e7fb30be98f/src/cargo/sources/path.rs#L458-L478

There are some differences between ignore and walkdir crates here, so this won't be a 1:1 copypaste.

Notes

No response

Version

No response