Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile contracts under cfg(test) for foundry tests #847

Open
maciektr opened this issue Oct 31, 2023 · 3 comments
Open

Compile contracts under cfg(test) for foundry tests #847

maciektr opened this issue Oct 31, 2023 · 3 comments
Labels
cairo Contribution to Cairo compiler

Comments

@maciektr
Copy link
Contributor

maciektr commented Oct 31, 2023

Starknet-foundry relies on Scarb's starknet-contract target to compile contracts that can be used during test runtime. There is a use case for foundry's users to create contracts only for this purpose. Such contracts could be defined either in test files, or under cfg(test) attribute. As of now, Scarb does not have any interface that would enable foundry to compile them.
cc @MaksymilianDemitraszek

@mkaput
Copy link
Member

mkaput commented Oct 31, 2023

I think this could lead to smearing too much abilities everywhere. Why not just establishing a pattern to write contracts in separate packages and focus on implementing #717 instead?

@maciektr
Copy link
Contributor Author

Decided to go with #717 instead

@maciektr maciektr closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
@maciektr maciektr reopened this Nov 24, 2023
@maciektr
Copy link
Contributor Author

maciektr commented Dec 8, 2023

related: foundry-rs/starknet-foundry#471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cairo Contribution to Cairo compiler
Projects
Status: Backlog
Development

No branches or pull requests

2 participants