Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically determine cairoVersion in StandardAccount #383

Open
DelevoXDG opened this issue Dec 28, 2023 · 0 comments
Open

Automatically determine cairoVersion in StandardAccount #383

DelevoXDG opened this issue Dec 28, 2023 · 0 comments
Labels
enhancement New feature or request priority: low

Comments

@DelevoXDG
Copy link
Collaborator

DelevoXDG commented Dec 28, 2023 •
edited

Feature Request

We should consider automatically determining cairoVersion in StandardAccount, similarly to how it's done in starknet.py:
https://github.com/software-mansion/starknet.py/blob/1859b5d2d2be9963c2fa178567cc2ba82a282823/starknet_py/net/account/account.py

Currently, Cairo 0 is assumed as account contract version by default, and if someone doesn't know about this, the error reason input too long for arguments, sometimes encoded as a Felt, is not helpful at all.
@DelevoXDG DelevoXDG added enhancement New feature or request priority: low labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DelevoXDG