Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure idiomatic Java code #403

Open
DelevoXDG opened this issue Jan 31, 2024 · 0 comments · May be fixed by #463
Open

Ensure idiomatic Java code #403

DelevoXDG opened this issue Jan 31, 2024 · 0 comments · May be fixed by #463
Assignees
@franciszekjob
Labels
enhancement New feature or request priority: medium

Comments

@DelevoXDG
Copy link
Collaborator

DelevoXDG commented Jan 31, 2024 •
edited

Feature Request

The codebase in some places diverges from principles outlined in README regarding idiomatic java code.

We should avoid using default values in interface methods, which is something that is present in some of the Account methods. We should also add @JvmOverloads in functions with default arguments where possible, e.g. EstimateFeeResponse.toResourceBounds()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciszekjob franciszekjob

Labels
enhancement New feature or request priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update codebase to ensure idiomatic Java code software-mansion/starknet-jvm
2 participants
@DelevoXDG @franciszekjob