Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sncast json workaround in DevnetClient #113

Open
1 of 2 tasks
DelevoXDG opened this issue Oct 30, 2023 · 3 comments · May be fixed by #114
Open
1 of 2 tasks

Remove sncast json workaround in DevnetClient #113

DelevoXDG opened this issue Oct 30, 2023 · 3 comments · May be fixed by #114
Labels
blocked enhancement New feature or request

Comments

@DelevoXDG
Copy link
Collaborator

DelevoXDG commented Oct 30, 2023

Blocked by: foundry-rs/starknet-foundry#1093

@DelevoXDG DelevoXDG added the enhancement New feature or request label Oct 30, 2023
DelevoXDG added a commit that referenced this issue Oct 30, 2023
@DelevoXDG DelevoXDG linked a pull request Oct 30, 2023 that will close this issue
@Subbitoooo
Copy link

All right,to remove the JSON workaround in StarkNet, you can use native StarkNet data types and functions instead of converting data to JSON and back. This can make your code more efficient and easier to read. Hoping that This can help you to solve your problem. If you have any question, just ask me ;) .

@DelevoXDG
Copy link
Collaborator Author

DelevoXDG commented Nov 1, 2023

@Subbitoooo
Hi, I'm not sure what are you referring to, as this issue is not related to converting Starknet data types, but to the output of the tool used internally for testing.
This issue is dedicated to a workaround in DevnetClient, caused by the issue with cast tool mentioned in the description. This is a minor change and will be resolved in #114.

There are currently no any plans to refactor the way objects are serialized for interaction with JSON-RPC nodes.

@DelevoXDG DelevoXDG changed the title Remove json workaround Remove sncast json workaround in DevnetClient Nov 1, 2023
@THenry14
Copy link
Member

#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants