Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing optional params in favor of overloaded functions #135

Open
DelevoXDG opened this issue Jan 24, 2024 · 0 comments
Open

Consider removing optional params in favor of overloaded functions #135

DelevoXDG opened this issue Jan 24, 2024 · 0 comments
Labels
enhancement New feature or request priority: low

Comments

@DelevoXDG
Copy link
Collaborator

Feature Request

From https://github.com/software-mansion/starknet.swift/pull/129/files#r1455383229

I think the logic with StarknetOptionalExecutionParamsV3 is not ideal, and overloaded functions like in jvm would be better.
But to not further complicate this PR, I decided to follow the approach already used for v1 txs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DelevoXDG