Remove Goerli chain ID support #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
changed the title
franciszekjob
commented
May 13, 2024
| @@ -421,7 +421,7 @@ final class TypedDataTests: XCTestCase { | |||
| ( | |||
| Self.CasesRev0.tdValidate, | |||
| "0xcd2a3d9f938e13cd947ec05abc7fe734df8dd826", | |||
| "0x6038f35de58f40a6afa9d359859b2f930e5eb987580ba6875324cc4dbfcee" | |||
| "0x3b3fbdb1961ae09cb5b2716b07142e63930fb2eddc4842641ca1df7352766a1" | |||
There was a problem hiding this comment.
The change from Goerli to Sepolia in typed data jsons, resulted in new hashes calculated in tests. Therefore, all expected values affected by chain Id change, had to be updated.
DelevoXDG
reviewed
May 15, 2024
Tests/StarknetTests/Resources/TypedData/typed_data_rev_0_validate_example.json
Outdated
Show resolved
Hide resolved
DelevoXDG
approved these changes
May 15, 2024
Tests/StarknetTests/Resources/Accounts/starknet_open_zeppelin_accounts.json
Outdated
Show resolved
Hide resolved
…accounts.json Co-authored-by: Maksim Zdobnikau <43750648+DelevoXDG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
testMessageHashCalculationLinked issues
Closes #160
Breaking changes
StarknetChainId.goerli