From 7444ac616ca75421fb3219890d8fe965106a0ce8 Mon Sep 17 00:00:00 2001 From: Jeremy Rose Date: Wed, 31 Aug 2022 10:25:01 -0700 Subject: [PATCH] chore: drop unresponsive suppressor for menus (#35498) --- shell/browser/api/electron_api_menu_mac.mm | 2 -- shell/browser/api/electron_api_menu_views.cc | 4 ---- 2 files changed, 6 deletions(-) diff --git a/shell/browser/api/electron_api_menu_mac.mm b/shell/browser/api/electron_api_menu_mac.mm index eff18b2efd24c..c299a91814dd8 100644 --- a/shell/browser/api/electron_api_menu_mac.mm +++ b/shell/browser/api/electron_api_menu_mac.mm @@ -14,7 +14,6 @@ #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" #include "shell/browser/native_window.h" -#include "shell/browser/unresponsive_suppressor.h" #include "shell/common/keyboard_util.h" #include "shell/common/node_includes.h" @@ -156,7 +155,6 @@ base::mac::ScopedSendingEvent sendingEventScoper; // Don't emit unresponsive event when showing menu. - electron::UnresponsiveSuppressor suppressor; [menu popUpMenuPositioningItem:item atLocation:position inView:view]; } diff --git a/shell/browser/api/electron_api_menu_views.cc b/shell/browser/api/electron_api_menu_views.cc index 908ae1bc925c1..f4e3d3317d047 100644 --- a/shell/browser/api/electron_api_menu_views.cc +++ b/shell/browser/api/electron_api_menu_views.cc @@ -8,7 +8,6 @@ #include #include "shell/browser/native_window_views.h" -#include "shell/browser/unresponsive_suppressor.h" #include "ui/display/screen.h" using views::MenuRunner; @@ -39,9 +38,6 @@ void MenuViews::PopupAt(BaseWindow* window, int flags = MenuRunner::CONTEXT_MENU | MenuRunner::HAS_MNEMONICS; - // Don't emit unresponsive event when showing menu. - electron::UnresponsiveSuppressor suppressor; - // Make sure the Menu object would not be garbage-collected until the callback // has run. base::OnceClosure callback_with_ref = BindSelfToClosure(std::move(callback));