From c6a27cabecaf579e61c372a5be1c8e5c46d15145 Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Mon, 23 May 2022 16:39:50 +0200 Subject: [PATCH] test: use webContents.setWindowOpenHandler() in specs (#34310) --- spec-main/api-web-contents-spec.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/spec-main/api-web-contents-spec.ts b/spec-main/api-web-contents-spec.ts index c2f6151fd2d4f..29ff9e5f60996 100644 --- a/spec-main/api-web-contents-spec.ts +++ b/spec-main/api-web-contents-spec.ts @@ -1563,9 +1563,10 @@ describe('webContents module', () => { server.listen(0, '127.0.0.1', () => { const url = 'http://127.0.0.1:' + (server.address() as AddressInfo).port + '/'; w.webContents.once('did-finish-load', () => { - w.webContents.once('new-window', (event, newUrl, frameName, disposition, options, features, referrer) => { - expect(referrer.url).to.equal(url); - expect(referrer.policy).to.equal('strict-origin-when-cross-origin'); + w.webContents.setWindowOpenHandler(details => { + expect(details.referrer.url).to.equal(url); + expect(details.referrer.policy).to.equal('strict-origin-when-cross-origin'); + return { action: 'allow' }; }); w.webContents.executeJavaScript('a.click()'); }); @@ -1591,9 +1592,10 @@ describe('webContents module', () => { server.listen(0, '127.0.0.1', () => { const url = 'http://127.0.0.1:' + (server.address() as AddressInfo).port + '/'; w.webContents.once('did-finish-load', () => { - w.webContents.once('new-window', (event, newUrl, frameName, disposition, options, features, referrer) => { - expect(referrer.url).to.equal(url); - expect(referrer.policy).to.equal('no-referrer-when-downgrade'); + w.webContents.setWindowOpenHandler(details => { + expect(details.referrer.url).to.equal(url); + expect(details.referrer.policy).to.equal('no-referrer-when-downgrade'); + return { action: 'allow' }; }); w.webContents.executeJavaScript('window.open(location.href + "should_have_referrer")'); });