You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a user of the Solid Design System, I would like to utilize an additional attribute to be used for tracking implemenatation, as well as an additional attribute to be used for testing on each component, so that solid components can be used with the current tracking implementation and within the current testing structure.
Suggested Solution
A global script adds the following attributes to each component:
Tracking
key: data-sd-version
value: current version of the library (eg. 3.3.0)
Testing
key: data-sd-name
value: component name (eg. sd-button)
Implementation details
This should be implemented as a one-time effort for all components, so e. g. in the sd-element, being the base component.
The version could be easily replaced via Vite with some String replacement.
Not sure about the component name, but even that should be possible via connectedCallback, which sets the attribute containing the tag of this and maybe having some kind of regex which removes numbers followed by dashes.
DoR
Item has business value
Item all subtasks have been estimated by the team
Item is clear and well-defined
Item dependencies have been identified and documented
DoD
Documentation has been created/updated (if applicable)
Migration Guide has been created/updated (if applicable)
Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
Relevant stories (Features, A11y) are created/updated
Implementation works successfully on feature branch
The text was updated successfully, but these errors were encountered:
@mariohamann assigned to you in order to read through it and see if anything is missing. I could not find any information for the tracking part and especially no information about the priority.
@yoezlem assigned to you in order to prioritize. I did not create it as epic, as we only have dev implementation for it. The testing prio is medium IMO.
User Story
As a user of the Solid Design System, I would like to utilize an additional attribute to be used for tracking implemenatation, as well as an additional attribute to be used for testing on each component, so that solid components can be used with the current tracking implementation and within the current testing structure.
Suggested Solution
A global script adds the following attributes to each component:
key: data-sd-version
value: current version of the library (eg.
3.3.0
)key: data-sd-name
value: component name (eg.
sd-button
)Implementation details
This should be implemented as a one-time effort for all components, so e. g. in the
sd-element
, being the base component.connectedCallback
, which sets the attribute containing thetag
ofthis
and maybe having some kind of regex which removes numbers followed by dashes.DoR
DoD
feature
branchThe text was updated successfully, but these errors were encountered: