Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial page example https://www.solidjs.com/tutorial/bindings_refs?solved doesn't work #188

Open
aercolino opened this issue Sep 5, 2022 · 2 comments
Labels
tutorial Related to the tutorial

Comments

@aercolino
Copy link

Describe the bug

1st problem

The URL for the logo is given as https://dev.solidjs.com/img/logo/dark-without-wordmark/logo.svg but it should probably be https://www.solidjs.com/img/logo/dark-without-wordmark/logo.svg

2nd problem

I see two logos (macOS 12.5.1 + Chrome 105 / Firefox 104): one appears inside the canvas, and another appears inside the body. My solution has been to apply the mask to .my-canvas class instead of the canvas element.

image

Your Example Website or App

https://www.solidjs.com/tutorial/bindings_refs?solved

Steps to Reproduce the Bug or Issue

Reproduce

  1. Go to https://www.solidjs.com/tutorial/bindings_refs?solved
  2. Look at the results tab

Expected behavior

To see the one logo with animated colors inside the canvas

Screenshots or Videos

No response

Platform

  • OS: macOS 12.5.1
  • Browser: Chrome 105, Firefox 104, maybe others too

Additional context

Fix for the 1st problem

  1. Display the style.css tab
  2. Replace dev with www

Fix for the 2nd problem

  1. Replace canvas with my-canvas
  2. Display the main.jsx tab
  3. Add class="my-class" to the canvas element
@aercolino
Copy link
Author

The cause of the second logo is due to the fact that there is a div with a class luna-dom-highlighter which includes a second canvas element...

image

@ryansolid ryansolid transferred this issue from solidjs/solid Sep 6, 2022
@ryansolid
Copy link
Member

Thanks I've transferred this issue to docs.

@orenelbaum orenelbaum added the tutorial Related to the tutorial label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tutorial Related to the tutorial
Projects
None yet
Development

No branches or pull requests

3 participants