Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid-start: Docs for the plugin options should be more explicit about relative paths. #232

Open
viridia opened this issue Feb 10, 2023 · 2 comments

Comments

@viridia
Copy link

viridia commented Feb 10, 2023

The doc should mention that the paths for routesDir and other directory options are resolved relative to the appRoot directory; whereas appRoot is resolved relative to the current directory. I initially assumed that all paths would be treated the same, that is, resolved relative to currentDir.

Also, at the present time appRoot cannot be an absolute path. (This may be a bug - if not, it should be documented.)

@edemaine
Copy link
Contributor

Are you reading docs from https://docs.solidjs.com/? If so, the issue should be on the solid-docs-next repo. I can move it for you, but I'd like to know whether to just move this issue (which seems very clearly about the new docs) or all four of your issues (some of which I'm not sure).

@viridia
Copy link
Author

viridia commented Feb 12, 2023

The other three issues are about solid.js - only this one pertains to solid-start. I didn't realize that there were separate doc projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants