Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CssAnimation Example Page: Code Doesn't Work #240

Open
deshumake opened this issue Feb 27, 2023 · 0 comments
Open

CssAnimation Example Page: Code Doesn't Work #240

deshumake opened this issue Feb 27, 2023 · 0 comments

Comments

@deshumake
Copy link

The given code doesn't work on this page: https://www.solidjs.com/examples/cssanimations. If I remember correctly, there are 3 things wrong.

  1. The page errors unless TransitionGroup is removed at the bottom
  2. It looks like boolean expressions don't work too well either

Ryan posted some code almost identical to what's on the website, in this sandbox: https://codesandbox.io/s/basic-css-transition-36rln?file=/index.js. Using Ryan's code here, there is another issue: When trying to use typescript, an error is thrown because the type expected on line 46 for the beforeEnter event is an "Element", but "Element" doesn't have a style prop on it. Should this be changed to an "HTMLElement" because those have style props on them? To work around this in my project, I just made a new type and extended "Element" with style

Otherwise, Ryan's code works in the sandbox, and on my machine. Not sure why it doesn't work on the solid website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant