Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load Monaco Editor to unblock SSR process #67

Open
davedbase opened this issue Nov 28, 2021 · 3 comments
Open

Lazy load Monaco Editor to unblock SSR process #67

davedbase opened this issue Nov 28, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@davedbase
Copy link
Member

I'd really love the ability to include Solid REPL in Solid Site's SSR process. Unfortunately Monaco introduces side-effects when I attempt to do so. You can experience this on https://github.com/solidjs/solid-site/tree/solid-start-migration. A solution discussed on Discord is to lazy load Monaco itself but that might apparently pose some trouble for the top-level await.

Either way it would be really nice to get support for this. I'm hoping someone has some spare time to sink their teeth into it.

Thanks!

@davedbase davedbase added enhancement New feature or request help wanted Extra attention is needed labels Nov 28, 2021
@trusktr
Copy link
Contributor

trusktr commented Dec 23, 2021

include Solid REPL in Solid Site's SSR process

What would this do? Like render the initial HTML of the editor with the payload?

@milomg
Copy link
Member

milomg commented Mar 19, 2022

I think we can probably close this once solidjs/solid-site#261 gets merged, as an example of using solid-repl within SSR

@milomg
Copy link
Member

milomg commented Jul 7, 2022

One example of doing this is here: solidjs/solid-docs-next#70, but there seems to be a vite issue blocking us and causing an error about bundling two workers at the same time: https://app.netlify.com/sites/solid-docs/deploys/62b60ea52f4e28000aeb0792

Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants