Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spa-test breaks in Vite 4 due to hydration (data-hk) #674

Closed
birkskyum opened this issue Jan 20, 2023 · 2 comments · Fixed by #767
Closed

spa-test breaks in Vite 4 due to hydration (data-hk) #674

birkskyum opened this issue Jan 20, 2023 · 2 comments · Fixed by #767

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Jan 20, 2023

Part of #660

In spa-test, the combination of 'with index.html' and app.goto('/about') leads to this data-hk inconsistency in Vite 4:

Screenshot 2023-01-20 at 14 43 00

@ryansolid
Copy link
Member

ryansolid commented Jan 20, 2023

Hmm.. that suggests it is getting the server rendered code instead of client rendered. Some configuration issue only present in Vite 4. Maybe the way some setting is merged? Hmm..

I wonder if this is related to the dev mode issue. Some people are reporting their prod builds are getting dev code with Vite 4. Our dev setup might not be handling CSR mode right and this is exposing it. To be clear this test should pass regardless and there is an issue in how the config is being handled.

@birkskyum
Copy link
Contributor Author

birkskyum commented Jan 28, 2023

Is there an issue made for the dev mode issue anywhere? Where are these reports?

The prod/dev issue might be a result of this breaking change in vite 4 where the way to set prod/dev flags was being reworked: vitejs/vite#10996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants