-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and remove "dashboards" code #4860
Comments
This could be replaced with a default admin location. |
I doubt anyone is using this, but I guess we would have to deprecate and then remove this in a major version? |
Yeah, that's my thought. It was introduced alongside the permission sets, but I've never seen a store that used it. |
I would like to work on this issue. Is it still open? |
The new admin renders this kind of moot, but it couldn't hurt to still do this. |
@jarednorman Do you want to add deprecation warnings in the files listed above or just remove them? |
I think they should be deprecated first. |
As stated by @jarednorman (in solidusio#4860): > None of this provides any real value. Adding a custom dashboard is > trivial and I really don't think we need a custom permission set and > empty controller/view.
As stated by @jarednorman (in solidusio#4860): > None of this provides any real value. Adding a custom dashboard is > trivial and I really don't think we need a custom permission set and > empty controller/view.
As stated by @jarednorman (in solidusio#4860): > None of this provides any real value. Adding a custom dashboard is > trivial and I really don't think we need a custom permission set and > empty controller/view.
As stated by @jarednorman (in solidusio#4860): > None of this provides any real value. Adding a custom dashboard is > trivial and I really don't think we need a custom permission set and > empty controller/view.
As stated by @jarednorman (in solidusio#4860): > None of this provides any real value. Adding a custom dashboard is > trivial and I really don't think we need a custom permission set and > empty controller/view.
As stated by jarednorman (in solidusio#4860): > None of this provides any real value. Adding a custom dashboard is > trivial and I really don't think we need a custom permission set and > empty controller/view.
None of this provides any real value. Adding a custom dashboard is trivial and I really don't think we need a custom permission set and empty controller/view.
The text was updated successfully, but these errors were encountered: