Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of Redis Username in ExtAuth and Rate Limiter #9403

Open
sheidkamp opened this issue Apr 25, 2024 · 0 comments
Open

Handling of Redis Username in ExtAuth and Rate Limiter #9403

sheidkamp opened this issue Apr 25, 2024 · 0 comments
Labels
Type: Enhancement New feature or request

Comments

@sheidkamp
Copy link
Contributor

sheidkamp commented Apr 25, 2024

Gloo Edge Product

Enterprise

Gloo Edge Version

current

Is your feature request related to a problem? Please describe.

As part of addressing https://github.com/solo-io/gloo-mesh-enterprise/issues/15610, The ExtAuth and RateLimit services were updated to pull the Redis User from the REDIS_USER environment variable.

While we have the ability to set these (separately) with an environment variable via global.extensions.(extAuth|rateLimit).deployment.customEnv[].name, we should consider providing better UX

Describe the solution you'd like

Gloo Mesh handles this by making username part of the secret

Gloo Edge uses a secret to provide the Redis password, and a similar implementation would make sense.

Describe alternatives you've considered

It would be an improvement if we provided a Helm value to set the environment variable, but mirroring the Mesh approach would provide consistency and store the username with the password, which seems natural

Additional Context

This issue affects AWS Elasticache with AUTH,

The Gloo Mesh issue provides additional context

@sheidkamp sheidkamp added the Type: Enhancement New feature or request label Apr 25, 2024
@sheidkamp sheidkamp changed the title Expose RedisUsername in Helm for ExtAuth and Rate Limiter Handling of Redis Username in ExtAuth and Rate Limiter Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant