Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use twig blocks for form rendering #703

Open
2 of 4 tasks
core23 opened this issue Aug 8, 2016 · 4 comments
Open
2 of 4 tasks

Use twig blocks for form rendering #703

core23 opened this issue Aug 8, 2016 · 4 comments

Comments

@core23
Copy link
Member

core23 commented Aug 8, 2016

We should replace all <form> elements in the twig templates with the twig function form_start and form_end. We should also move the action and method (POST, GET) attribute to the PHP files.

This would decouples the business logic from the layout.

Todo

The following files contains form elements.

@core23
Copy link
Member Author

core23 commented Aug 14, 2016

Depends on sonata-project/SonataAdminBundle#4050, because we need to add something to the Datagrid.

@stale
Copy link

stale bot commented Jan 30, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2020
@SonataCI SonataCI removed the wontfix label Jan 30, 2020
@core23 core23 added the keep label Jan 31, 2020
@eerison
Copy link
Contributor

eerison commented Oct 13, 2022

Hey @core23 I saw that Resources/views/base_layout.html.twig was already checked as solved, But do you know which PR was it done 👀

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants