Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Deprecate this package #25

Open
AndrewGuenther opened this issue Feb 21, 2023 · 2 comments
Open

Proposal: Deprecate this package #25

AndrewGuenther opened this issue Feb 21, 2023 · 2 comments

Comments

@AndrewGuenther
Copy link
Collaborator

The approach this package takes to getting poetry dependencies predates a lot of major improvements which have been made to rules_python. I've made a sort of reference implementation here of what poetry support with the latest rules_python could look like here: https://github.com/AndrewGuenther/rules_python_poetry

In total, it's under 30 lines of code and it works quite smoothly. Compared to the relatively significant size of this implementation, I just don't see a compelling reason for this project to continue. To be clear, this isn't a shot at the maintainers here. I used this package for a long time and have made some contributions of my own, but the Bazel Python ecosystem has evolved past the need for much of the complexity here.

@njlr
Copy link
Collaborator

njlr commented Feb 22, 2023

The approach this package takes to getting poetry dependencies predates a lot of major improvements which have been made to rules_python. I've made a sort of reference implementation here of what poetry support with the latest rules_python could look like here: https://github.com/AndrewGuenther/rules_python_poetry

In total, it's under 30 lines of code and it works quite smoothly. Compared to the relatively significant size of this implementation, I just don't see a compelling reason for this project to continue. To be clear, this isn't a shot at the maintainers here. I used this package for a long time and have made some contributions of my own, but the Bazel Python ecosystem has evolved past the need for much of the complexity here.

This is indeed much simpler!

I was wondering if/how your solution handles different platforms? I think we need to do an export per platform?

Additionally, perhaps your method should be merged into this repo?

@SimonBiggs
Copy link

SimonBiggs commented Jun 8, 2023

Additionally, perhaps your method should be merged into this repo?

It looks like contributions to this repo are a bit of a dead end:

#23 (comment)

Thanks @AndrewGuenther for your re-implementation. I'll run with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants