how to use this in browser #45

gautamkrishnar · 2019-12-29T07:24:35Z

I cant see any specific builds for browsers. I tried using browserifly but it didn't worked. Can you guys let me know how can we use this for web browsers.

sonnyp · 2019-12-29T12:12:14Z

I tried using browserifly but it didn't worked

Browserify works fine with aria2.js, double check your configuration / usage .

We use to have the browser bundle shipped with aria2.js . I would be open to re-introduce it. I just assumed everybody used templates and build systems nowadays when writing web apps. What is your use case?

gautamkrishnar · 2019-12-29T12:19:51Z

@sonnyp thanks for the reply, I am developing a download manager extension for chrome. I tried making a file using the following command:

browserify index.js -o op.js

But when i tried to include it via script <script src="op.js" type="text/javascript"> i couldn't find the Aria2 object in the window. So that i can't do

var x = new Aria2();

Yes, Its better to have a browser bundle shipped with all releases.

sonnyp · 2019-12-29T12:56:27Z

If you want to use a global you need to use the standalone mode.

Something like

browserify index.js -o Aria2.js -s Aria2

sonnyp · 2019-12-29T12:56:47Z

See https://github.com/browserify/browserify#usage

gautamkrishnar · 2019-12-29T13:15:13Z

Okay Thanks will check that 👍

sonnyp · 2019-12-29T13:36:42Z

I'll leave this open as a reminder to re-introduce the browser bundle

gautamkrishnar · 2019-12-29T13:38:51Z

👍 Thats great.

gautamkrishnar · 2020-05-24T07:22:08Z

@sonnyp any idea why you guys removed the browser bundle?

ChiaYen-Kan · 2023-03-23T06:29:46Z

Hi @sonnyp
i try build from current source code and use "bundle.js" in browser, but i got a error

bundle.js:519 Uncaught ReferenceError: global is not defined
    at new JSONRPCClient (bundle.js:519:22)
    at new Aria2 (bundle.js:706:3)
    at aria2.js.html:6:25

this is my test code

<html>
    <head>
        <meta charset="utf-8">
        <script type="application/javascript" src="bundle.js"></script>
        <script>
            var aria2 = new Aria2();
            aria2.call("addUri",
                ["https://fastly.picsum.photos/id/337/536/354.jpg?hmac=T7nJ4MjfcTPFuaaLRH_1zwqyOFzmldcV-f5abNr2MyE"],
            );
        </script>
    </head>
</html>

how to fix this error?

thank you

pierrbt · 2023-08-08T21:21:45Z

@ChiaYen-Kan, do you still want to make this work ? I've found a solution

ChiaYen-Kan · 2023-08-09T00:54:21Z

Hi @pierrbt
i also have a solution, it's work, but i don't know is good solution or bad solution 🤔
following is my solution, base on c960ebb in main branch

From 26b51a31699d3fd299dafe6566f3c79480301286 Mon Sep 17 00:00:00 2001
From: ChiaYen Kan <***>
Date: Fri, 24 Mar 2023 16:37:03 +0800
Subject: [PATCH] fix can't run in browser

---
 src/JSONRPCClient.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/JSONRPCClient.js b/src/JSONRPCClient.js
index 8bab3aa..059babc 100644
--- a/src/JSONRPCClient.js
+++ b/src/JSONRPCClient.js
@@ -4,6 +4,8 @@ import Deferred from "./Deferred.js";
 import promiseEvent from "./promiseEvent.js";
 import JSONRPCError from "./JSONRPCError.js";
 
+var global = global || globalThis;
+
 class JSONRPCClient extends EventEmitter {
   constructor(options) {
     super();
@@ -12,7 +14,7 @@ class JSONRPCClient extends EventEmitter {
 
     Object.assign(
       this,
-      { WebSocket: global.WebSocket, fetch: global.fetch.bind(this) },
+      { WebSocket: global.WebSocket, fetch: global.fetch.bind(global) },
       this.constructor.defaultOptions,
       options
     );
-- 
2.41.0.windows.3

thank you

pierrbt · 2023-08-09T00:57:00Z

@ChiaYen-Kan,
Personally, I've just changed global to window, and added the events depencies.

ChiaYen-Kan · 2023-08-09T01:56:14Z

Hi @pierrbt
i am not a web developer, i just want to it can work in my little project
may be someone can make it best
thank you

gautamkrishnar closed this as completed Dec 29, 2019

sonnyp reopened this Dec 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

how to use this in browser #45

how to use this in browser #45

gautamkrishnar commented Dec 29, 2019

sonnyp commented Dec 29, 2019 •

edited

gautamkrishnar commented Dec 29, 2019 •

edited

sonnyp commented Dec 29, 2019

sonnyp commented Dec 29, 2019

gautamkrishnar commented Dec 29, 2019

sonnyp commented Dec 29, 2019

gautamkrishnar commented Dec 29, 2019

gautamkrishnar commented May 24, 2020

ChiaYen-Kan commented Mar 23, 2023

pierrbt commented Aug 8, 2023

ChiaYen-Kan commented Aug 9, 2023

pierrbt commented Aug 9, 2023 •

edited

ChiaYen-Kan commented Aug 9, 2023

how to use this in browser #45

how to use this in browser #45

Comments

gautamkrishnar commented Dec 29, 2019

sonnyp commented Dec 29, 2019 • edited

gautamkrishnar commented Dec 29, 2019 • edited

sonnyp commented Dec 29, 2019

sonnyp commented Dec 29, 2019

gautamkrishnar commented Dec 29, 2019

sonnyp commented Dec 29, 2019

gautamkrishnar commented Dec 29, 2019

gautamkrishnar commented May 24, 2020

ChiaYen-Kan commented Mar 23, 2023

pierrbt commented Aug 8, 2023

ChiaYen-Kan commented Aug 9, 2023

pierrbt commented Aug 9, 2023 • edited

ChiaYen-Kan commented Aug 9, 2023

sonnyp commented Dec 29, 2019 •

edited

gautamkrishnar commented Dec 29, 2019 •

edited

pierrbt commented Aug 9, 2023 •

edited