sosreport
tests folder flake8 #3513
-
|
Going through some old PRs and such, we are having to pick up redundant code or variables not being using if people are updating or writing tests. Is there any reason why we don't run flake8 against the |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
Mostly historical reasons - we never did before, so I didn't include them during the switch to avocado. That plus the idea at the time that tests don't get packaged. I'm now aware that at least some Debian/Ubuntu packaging does in fact do that, so I have no objections to changing this and including it in the linting. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, makes sense. I've started a PR, will do further on this too. My idea was that if we want to start writing more tests (which is Canonical folks intend to do) it would be good to have good code practice on the tests as well as the main code. This will ensure we continue to have good practice across the whole codebase |
Beta Was this translation helpful? Give feedback.
Mostly historical reasons - we never did before, so I didn't include them during the switch to avocado. That plus the idea at the time that tests don't get packaged. I'm now aware that at least some Debian/Ubuntu packaging does in fact do that, so I have no objections to changing this and including it in the linting.