Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify dependencies for each target/module #699

Open
cgrindel opened this issue Oct 17, 2023 · 3 comments
Open

Explicitly specify dependencies for each target/module #699

cgrindel opened this issue Oct 17, 2023 · 3 comments

Comments

@cgrindel
Copy link

Describe the bug
We would like to build with explicit modules enabled.

To Reproduce
Steps to reproduce the behavior:

  1. Execute the build with these flags: swift build --use-integrated-swift-driver --experimental-explicit-module-build

Expected behavior
It should succeed

Setup (please complete the following information):

  • OS: MacOS 14.0
  • Version of soto: 6.8.0
  • Swift: 5.9
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-5.9.0.128.108 clang-1500.0.40.1)
Target: x86_64-apple-macosx14.0

Additional context
I am willing to take a crack at reworking the Package.swift to explicitly specify the dependencies. Just let me know.

Related to cgrindel/rules_swift_package_manager#647.

@cgrindel cgrindel changed the title Would you be open to a pull request to update Package.swift to build with explicit module support enabled? Support building with explicit module support enabled Oct 17, 2023
@cgrindel
Copy link
Author

It looks like a number of dependencies will need to be updated, as well.

@cgrindel
Copy link
Author

On second thought, it looks like getting this and all of the transitive dependencies to build with swift build --use-integrated-swift-driver --experimental-explicit-module-build might be premature. Alternatively, could we update Package.swift to include all of the direct dependencies for each target?

@cgrindel cgrindel changed the title Support building with explicit module support enabled Explicitly specify dependencies for each target/module Oct 17, 2023
@adam-fowler
Copy link
Member

The Package.swift is auto-generated by the swift script scripts/generate-package.swift. It uses the template scripts/templates/package.swift. So you'll need to edit that and run the above script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants