Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usort() deprecation (PHP 8.0) #74

Open
arokettu opened this issue Sep 28, 2020 · 2 comments · May be fixed by #78
Open

usort() deprecation (PHP 8.0) #74

arokettu opened this issue Sep 28, 2020 · 2 comments · May be fixed by #78

Comments

@arokettu
Copy link 

Deprecation Notice: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in .../vendor/sllh/composer-versions-check/src/VersionsCheck.php:54
@soullivaneuh soullivaneuh mentioned this issue Nov 9, 2020
Closed
kohenkatz added a commit to kohenkatz/composer-versions-check that referenced this issue Oct 1, 2021
@kohenkatz
Fix deprecation notice in PHP 8.x
3b06672 
According to the documentation, all versions of PHP support the `usort` callable parameter returning an `integer`. While earlier versions silently accepted a `boolean`, PHP 8.x throws a deprecation notice:

```
Deprecation Notice: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in C:\Users\MY_USER\AppData\Roaming\Composer\vendor\sllh\composer-versions-check\src\VersionsCheck.php:54
```

This fix (based on [this comment](soullivaneuh#75 (comment))) eliminates this notice.

fixes soullivaneuh#74
@kohenkatz kohenkatz linked a pull request Oct 1, 2021 that will close this issue
Open
@dereuromark
Copy link
Contributor

Any update on this?

@dereuromark
Copy link
Contributor

This project is clearly completely dead for years.

I created a new fork ( https://github.com/dereuromark/composer-versions-check ).
Let's contribute there with PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecation notice in PHP 8.x kohenkatz/composer-versions-check
2 participants
@dereuromark @arokettu