Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update #145

Open
jnhooper opened this issue Jul 23, 2020 · 0 comments
Open

README update #145

jnhooper opened this issue Jul 23, 2020 · 0 comments

Comments

@jnhooper
Copy link

Small thing i noticed on the readme for inner ref it says it only accepts a function but in looking at the code i see the prop type is expecting a function or an object.
https://github.com/souporserious/react-measure/blob/master/src/with-content-rect.js#L17
and when we actually use it it's checking it's type again
https://github.com/souporserious/react-measure/blob/master/src/with-content-rect.js#L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant