Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on componentWillUpdate #74

Open
LeNiglo opened this issue Oct 5, 2019 · 0 comments
Open

Warning on componentWillUpdate #74

LeNiglo opened this issue Oct 5, 2019 · 0 comments

Comments

@LeNiglo
Copy link

LeNiglo commented Oct 5, 2019

Hey there,

Really great library, working perfectly, no issues to report on my side.
But React warns me about componentWillUpdate being renamed.

Here is the warning :

Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: Player

Nothing to worry at the moment, but you will have to update to fix this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant