Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour about the interaction between the stepper tool and the frontend #2833

Open
FYL2003 opened this issue Mar 5, 2024 · 3 comments
Labels
minor Less important than important, but more than nice-to-have

Comments

@FYL2003
Copy link

FYL2003 commented Mar 5, 2024

Unexpected flashing of the stepper tool icon.
Expected behaviour: no flashing occurs (The CSE machine does not have this issue; it might be a useful source for referencing).

Order of execution to trigger the problem:

  1. Run the program in stepper tool.
  2. Change to Introduction setup.
  3. Run the program in the setup.

Figures related to the issue:
IMG_7712
IMG_7713
IMG_7714
IMG_7715
(The figures are in the order in which the problem was triggered.)

For detailed behaviour, please check out the video clips attached.

IMG_7710.MOV
@FYL2003 FYL2003 added the minor Less important than important, but more than nice-to-have label Mar 5, 2024
@martin-henz
Copy link
Member

Thanks for posting this. Same behavior for all §1 and §2 languages: Source and Source Typed.

@RichDom2185
Copy link
Member

@leeyi45 could you look into this if you're free? Might/not be related to your refactor recently.

@leeyi45
Copy link
Contributor

leeyi45 commented Mar 20, 2024

Yes this definitely looks like a result of the refactor.

The main issue is that specifically in the case of the subst-visualizer, it sends BEGIN_ALERT_SIDE_CONTENT before the SPAWN_SIDE_CONTENT event is sent. So the END_ALERT_SIDE_CONTENT event doesn't trigger until the next evaluation of any program.

Wrote up a quick fix for this issue, but we definitely need to refactor how the frontend evaluates code.

@leeyi45 leeyi45 mentioned this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Less important than important, but more than nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants