Fix #2833 #2859
Closed
Fix #2833 #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So upon further debugging, I think my final conclusion remains that how running code in the frontend needs to be refactored completely before this issue can be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain tabs (such as the substitution visualizer) could send their alert after dynamic tabs have already been spawned. This causes the alert to be displayed on the next evaluation, where
BEGIN_ALERT_SIDE_CONTENTfinallytakes aSPAWN_SIDE_CONTENT.This PR fixes this issue and also removes the
sideContentobject from workspaces.Though this resolves #2833, work should probably be done to refactor and simplify how the frontend evaluates code.