Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate Tab Loading to Frontend #2860

Open
leeyi45 opened this issue Mar 20, 2024 · 0 comments
Open

Relocate Tab Loading to Frontend #2860

leeyi45 opened this issue Mar 20, 2024 · 0 comments
Labels
proposal Tentative suggestion inviting discussion

Comments

@leeyi45
Copy link
Contributor

leeyi45 commented Mar 20, 2024

Right now there are two steps to tab loading:

  • js-slang first reads from tab files and then evaluates them
  • Frontend calls that raw tab to turn it into a ModuleSideContent

The idea of a "Tab" is entirely a frontend concept: thus I propose that we move the loading of module side content into the frontend. I think this would do us some good by continuing the separate the responsibilities between js-slang and the frontend.

@leeyi45 leeyi45 added the proposal Tentative suggestion inviting discussion label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Tentative suggestion inviting discussion
Projects
None yet
Development

No branches or pull requests

1 participant