Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent: implement createFileSystemWatcher shim #4136

Open
valerybugakov opened this issue May 10, 2024 · 1 comment
Open

Agent: implement createFileSystemWatcher shim #4136

valerybugakov opened this issue May 10, 2024 · 1 comment
Labels
agent cody

Comments

@valerybugakov
Copy link
Member

valerybugakov commented May 10, 2024 •
edited

  • Required for vscodeGitAPI.onDidOpenRepository and vscode.workspace.onDidChangeWorkspaceFolders.
  • Multiple existing product features (e.g. Repo Picker) depend on these APIs while they are not supported in clients other than VS Code.

  • cody/agent/src/vscode-shim.ts

    Line 349 in c49642c

    createFileSystemWatcher: () => emptyFileWatcher, // TODO: used for codyignore and custom commands
@github-actions github-actions bot added the cody label May 10, 2024
This was referenced May 10, 2024
Open
Merged
@olafurpg
Copy link
Member

File watching is very expensive to operate in large repositories, we should lean heavily on the editor’s existing file watchers over rolling our own.

@valerybugakov valerybugakov mentioned this issue May 14, 2024
Open
valerybugakov added a commit that referenced this issue May 14, 2024
@valerybugakov
Cody Ignore: remove the Git extension shim (#4115)
edff06a 
- Disables the Git extension shim in the agent. Documents places where we need to implement fallback methods.
- Fixes the Cody Ignore behavior in the agent where the shim returned empty values for most repository fields (e.g., remoteUrls).
- Functional changes:
    - The agent's `git` capability has been disabled.
    - We won't have commit ID logged in non-VS Code clients: https://github.com/sourcegraph/cody/blob/e01888ca5cf784ca5e118f8ef9204be2496b71c5/vscode/src/chat/chat-view/SimpleChatPanelProvider.ts#L423
    - Follow-up required #4139
- Other follow-up issues:
    - #4165
    - #4136
    - #4137
    - #4138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent cody
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olafurpg @valerybugakov